New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in comments #5738

Open

soma-git-practice wants to merge 1 commit into heartcombo:main from soma-git-practice:is_this_typo_models_in_lockable

+1 −1

soma-git-practice commented Dec 4, 2024

Is this typo?
Sorry, I can't English.

I set pry to confirm.

# lib/devise/models/lockable.rb:90

# Overwrites active_for_authentication? from Devise::Models::Activatable for locking purposes
# by verifying whether a user is active to sign in or not based on locked?
def active_for_authentication?
  binding.pry
  super && !access_locked?
end

I ran this to confirm.

bin/test test/models/lockable_test.rb:93

I ran this to confirm.

method(__method__).super_method.source_location
# => [~~~/lib/devise/models/confirmable.rb", 144]

method(__method__).super_method.super_method.source_location
# => [~~~/lib/devise/models/authenticatable.rb", 89]

method(__method__).super_method.super_method.super_method.source_location
# => nil


          Fix typo in comments

a78ad3f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet