Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update argument name for config.warden #5746

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update argument name for config.warden #5746

wants to merge 1 commit into from
+8 −8

Conversation

c960657
Copy link

@c960657 c960657 commented Dec 17, 2024

The argument for the block passed to config.warden is no a Warden::Manager instance but a Warden::Config instance, but it is confusingly named manager in the generated file.

I suggest renaming this to warden_config for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@c960657