Merge attributes with wrapper_options #1301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
. Please add a CHANGELOG entry.
|
We need to make the test conditional to the Rails version. if ActionPack::VERSION::MAJOR == '4' && ActionPack::VERSION::MINOR >= '2' |
rafaelfranca
force-pushed
the
hct-merge-wrapper-options
branch
from
0adaf41 to
be19931
Compare
Improve `merge_wrapper_options` method support other types with write, rewrite and merge attributes.
rafaelfranca
force-pushed
the
hct-merge-wrapper-options
branch
from
be19931 to
9d4e5cd
Compare
| oldval + Array(newval) | ||
| wrapper_options.merge(options) do |key, oldval, newval| | ||
| case key.to_s | ||
| when "class" |
There was a problem hiding this comment.
@rafaelfranca makes sense to freeze these Strings? ❄️
There was a problem hiding this comment.
I prefer to not, unless we have proof that this will improve significantly the performance of the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the #1278 issue modified the method of
merge_wrapper_optionsto support duplicated values.closes #1278