Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Remove log lines from between libsecp's and Core's summaries #254

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Jul 2, 2024

This PR addresses #192 (comment).

Additionally, fixed a bug in the translate target for the -DBUILD_GUI=ON -DENABLE_WALLET=OFF configuration.

hebasto added 4 commits July 2, 2024 19:04
This change ensures that these checks log won't be printed in between of
the secp256k1's and Bitcoin Core's summaries.
This change ensures that this check log won't be printed in between of
the secp256k1's and Bitcoin Core's summaries.
@hebasto hebasto added the bug Something isn't working label Jul 2, 2024
@hebasto hebasto added this to the Ready for master milestone Jul 2, 2024
@m3dwards
Copy link

m3dwards commented Jul 3, 2024

ACK 2995f0f

On cmake-staging branch I saw GUI and FUZZ messages in between summaries and I also saw an error when ENABLE_WALLET=OFF. All these things are fixed in this PR.

I also checked that the new way of checking if QT library is SHARED_LIBRARY or STATIC_LIBRARY worked as intended by building with and without a depends toolchain file and printing the value of the variable.

@hebasto hebasto merged commit 5fb74dd into cmake-staging Jul 3, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants