Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Fix compile definitions for crc32c target #258

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Jul 4, 2024

This PR aligns the code with the master branch:

if ENABLE_SSE42
CRC32C_CPPFLAGS_INT += -DHAVE_SSE42=1
else
CRC32C_CPPFLAGS_INT += -DHAVE_SSE42=0
endif
if ENABLE_ARM_CRC
CRC32C_CPPFLAGS_INT += -DHAVE_ARM64_CRC32C=1
else
CRC32C_CPPFLAGS_INT += -DHAVE_ARM64_CRC32C=0
endif

This change aligns the code with the master branch. It defines
`HAVE_SSE42` and `HAVE_ARM64_CRC32C` to 0 when the corresponding feature
is not available.
@fanquake
Copy link

fanquake commented Jul 4, 2024

When did this break?

@hebasto
Copy link
Owner Author

hebasto commented Jul 4, 2024

When did this break?

It's hard to say. However, the initial implementation was correct.

@hebasto hebasto added this to the Ready for master milestone Jul 4, 2024
@hebasto hebasto added the bug Something isn't working label Jul 4, 2024
@hebasto
Copy link
Owner Author

hebasto commented Jul 4, 2024

When did this break?

In #171.

Copy link

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 36a2b9b

@hebasto hebasto merged commit 292e7da into cmake-staging Jul 11, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants