Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite HED string parsing and splitting as classes #203

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

happy5214
Copy link
Member

This PR converts the two remaining procedural modules in parser to classes.

This bans all characters in the C0 and C1 control code ranges, using
the unicode-name NPM module to display the Unicode names of any
invalid characters.
@happy5214 happy5214 added dependencies Pull requests that update a dependency file quality Code quality, not must-fix tests Issues related to testcases parsing String parsing labels Oct 11, 2024
@happy5214 happy5214 added this to the 3.15.5 milestone Oct 11, 2024
@happy5214 happy5214 requested a review from VisLab October 11, 2024 13:25
@happy5214 happy5214 self-assigned this Oct 11, 2024
@happy5214 happy5214 marked this pull request as ready for review October 11, 2024 18:29
@happy5214 happy5214 merged commit 70a3681 into master Oct 11, 2024
7 of 9 checks passed
@happy5214 happy5214 deleted the rewrite-split-hed-string branch October 11, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file parsing String parsing quality Code quality, not must-fix tests Issues related to testcases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants