Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax upper bound to accommodate ansi-terminal-1.0 #486

Merged
merged 1 commit into from
May 19, 2023
Merged

Relax upper bound to accommodate ansi-terminal-1.0 #486

merged 1 commit into from
May 19, 2023

Conversation

mpilgrem
Copy link
Contributor

ansi-terminal-1.0 is released on Hackage.

See also commercialhaskell/stackage#6976.

Tested by building with Stack >= 2.9.3 and stack.yaml:

resolver: lts-18.28

packages:
- hedgehog
- hedgehog-corpus
- hedgehog-dieharder
- hedgehog-example
- hedgehog-quickcheck
- hedgehog-test-laws

extra-deps:
- ansi-terminal-1.0
- ansi-terminal-types-0.11.5
- QuickCheck-2.13.2@sha256:636e7265bf75122e7e2f97627c47aad3b772ee3b35b134cafb6095116ce8d07a,6974
- random-1.1@sha256:7b67624fd76ddf97c206de0801dc7e888097e9d572974be9b9ea6551d76965df,1777
- splitmix-0.0.5@sha256:4a49661be63f5aea0e132e9ab51be918789bb4dceb4ab9b15b85ba9cbbef5999,5412

allow-newer: true
allow-newer-deps:
- concurrent-output

@moodmosaic
Copy link
Member

Thank you, @mpilgrem. Would it be easy to rebase this? It shows conflicts in hedgehog.cabal

@moodmosaic
Copy link
Member

Based on the release notes on hackage, relaxing upper bound to accommodate ansi-terminal-1.0 looks good.

@moodmosaic moodmosaic merged commit 3fee0d3 into hedgehogqa:master May 19, 2023
@ysangkok
Copy link
Contributor

@moodmosaic Would it be possible to make a Hackage revision? Hedgehog was thrown out of Stackage because of this bound.

@moodmosaic
Copy link
Member

@ysangkok, of course, thanks for the heads up.

@mpilgrem mpilgrem deleted the ansi-terminal branch June 21, 2023 10:05
@moodmosaic
Copy link
Member

@ysangkok, done. https://hackage.haskell.org/package/hedgehog-1.3. Thank you 👍

@moodmosaic
Copy link
Member

Hmm... hackage seems happy, but all CI jobs keep failing.

@ysangkok
Copy link
Contributor

It looks like it's trying to build hedgehog-quickcheck as part of the test suite, but hedgehog-quickcheck has a version bound on hedgehog, and it doesn't accept 1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants