Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(url): fix clickable repo name in grid/table layout #114

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

tizee
Copy link
Contributor

@tizee tizee commented Jun 25, 2022

Checklist

  • My code is properly formatted using the latest black
  • I have added/updated tests if needed
  • I have tried running my code manually
  • I have checked for spelling errors

Description

Right now it only support clickable repo names in list layout by default.

        title = Text(repo["full_name"], overflow="fold")
        title.stylize(f"yellow link {repo['html_url']}")

Clickable links to repos are missing in both grid layout and table layout.

My PR added these missing links to get a coherent behavior of repo names across all layouts.

This PR also fixes #112

@tizee
Copy link
Contributor Author

tizee commented Jun 25, 2022

Maybe we can also update the README.md to include this existing feature because I notice that now there is words on it.

From the view of a new user, I have no clue that I could click and the name to jump unless I tried to do so in list layout. Hence, this incoherent behavior between list layout and others would make the user confused. Including this feature in the doc would make this tool more user-friendly.

@hedyhli
Copy link
Owner

hedyhli commented Oct 9, 2022

This looks good, however I'll have to test this when I'm free. Thanks!

@hedyhli hedyhli merged commit 3df068c into hedyhli:main Oct 9, 2022
@hedyhli
Copy link
Owner

hedyhli commented Oct 9, 2022

@allcontributors please add @tizee for code

@allcontributors
Copy link
Contributor

@hedyhli

I've put up a pull request to add @tizee! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add linkable jumping click?
2 participants