-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gtrending for fetching GitHub trending instead of scraping the web #86
Conversation
@hedythedev Thank you for your review! I fixed it.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, it seems that the test only fails in some cases. Currently it does not fail at all for me locally, will keep looking for where the problem is
@hedythedev Thank you for your review! I fixed it 🔧 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should have been .replace("-", " ")
not .replace("-", "")
(the space), but no worries I will fix it, thanks for your contributions!
@allcontributors please add @odmishien for code |
@hedythedev I've put up a pull request to add @odmishien! 🎉 |
resolves #82
Checklist
Description
convert_gtrending_repo_to_repo
that convert gtrending_repo dict to github uses onerequirements.txt
andsetup.py