Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] check if the owner is active when returning ownership (ExtensibleLoadManager) #57

Closed
wants to merge 1 commit into from

Conversation

heesung-sn
Copy link
Owner

@heesung-sn heesung-sn commented Dec 24, 2023

Motivation

When a broker shutdown or get killed, the leader broker will get notified and soon reassign the orphan bundle ownerships. Meanwhile, the ownwershiop lookup to these orphan bundles should be deferred til the new brokers own them. This will further reduce the lookup request retries when brokers are shutdown or get killed.

Modifications

In ServiceUnitStateChannelImpl.getOwnerAsync, additionally, check if the current owner broker is active or not in the broker registry. If active, return the current owner. Otherwise, defer the ownership lookup requests til the new owner owns it.

Verifying this change

  • Make sure that the change passes the CI checks.

Added a test case testActiveGetOwner to cover this.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@heesung-sn heesung-sn closed this Dec 27, 2023
@heesung-sn heesung-sn deleted the getActiveOwner branch April 2, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant