Skip to content
This repository has been archived by the owner on Feb 16, 2022. It is now read-only.

Mage2 108/change/create order from push #116

Merged
merged 30 commits into from
Nov 25, 2019

Conversation

Ryouzanpaku
Copy link
Member

No description provided.

Also added a negative test to prevent unintentional order creation.
Also added a negative test to prevent unintentional order creation.
…om_push' into MAGE2-108/change/create_order_from_push

# Conflicts:
#	Helper/Payment.php
…reate_order_from_push

# Conflicts:
#	Controller/Index/Push.php
#	Controller/Index/Response.php
@buffcode
Copy link

Please merge. Customers who exit the payment process before returning to the shop have paid but won't have an order within Magento.

Copy link
Member

@sixer1182 sixer1182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mir sind ein paar Sachen aufgefallen

Controller/Index/Push.php Outdated Show resolved Hide resolved
Controller/Index/Push.php Show resolved Hide resolved
Controller/Index/Push.php Show resolved Hide resolved
Controller/Index/Push.php Show resolved Hide resolved
Helper/Order.php Outdated Show resolved Hide resolved
Test/Integration/Controller/Index/PushHandlingTest.php Outdated Show resolved Hide resolved
Test/Integration/IntegrationTestAbstract.php Show resolved Hide resolved
Test/Integration/IntegrationTestAbstract.php Show resolved Hide resolved
Test/Integration/Controller/Index/PushHandlingTest.php Outdated Show resolved Hide resolved
Test/Integration/Controller/Index/PushHandlingTest.php Outdated Show resolved Hide resolved
Test/Integration/Controller/Index/PushHandlingTest.php Outdated Show resolved Hide resolved
Test/Integration/Controller/Index/PushHandlingTest.php Outdated Show resolved Hide resolved
@Ryouzanpaku Ryouzanpaku merged commit 1cc73a8 into develop Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants