Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SocketConfiguration.java #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update SocketConfiguration.java #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/com/heimuheimu/naivecache/net/SocketConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ public class SocketConfiguration {
config.setSendBufferSize(32 * 1024);
config.setReceiveBufferSize(32 * 1024);
config.setConnectionTimeout(30000);
config.setConnectionTimeout(30000);
config.setConnectionTimeout(30000);
Comment on lines +58 to +59
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the connection timeout three times consecutively is redundant and could be a logic error.

-		config.setConnectionTimeout(30000);
-		config.setConnectionTimeout(30000);

Remove the redundant calls to setConnectionTimeout.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
config.setConnectionTimeout(30000);
config.setConnectionTimeout(30000);
config.setConnectionTimeout(30000);

DEFAULT = config;
}

Expand Down