[BUGFIX] Options not set for typo3_console and coreapi detection #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks similar to my pull request #6 |
|
Indeed, but you missed one file ;) |
|
@jacobsenj @SomeBdyElse This indeed looks like a nobrainer fix. Can you both acknowledge on a canonical fix and push a rebased version of it (and then close the stale pull request). I will then merge it asap. Thanks |
|
@helhum Please use this pull request. It comprises my own pull request entirely. |
This fixes the missing options for typo3_console and coreapi extension detection for CompareDatabaseTask and FlushCachesTask.
|
I rebased the two commits into one. |
helhum
added a commit
that referenced
this pull request
Jun 20, 2015
[BUGFIX] Options not set for typo3_console and coreapi detection
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the missing options for typo3_console and coreapi extension
detection for CompareDatabaseTask and FlushCachesTask (#8).