Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archetype: add support for conditional blocks #993

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Archetype: add support for conditional blocks #993

wants to merge 2 commits into from

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Oct 18, 2023

fix #747

@tvallin
Conditional Block
f07d6e4 
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin added enhancement New feature or request archetype labels Oct 18, 2023
@tvallin tvallin self-assigned this Oct 18, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 18, 2023
romain-grecourt
romain-grecourt reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Few asks:

  • Add some negative tests
  • Check that when using ClientCompiler / ScriptSerializer empty blocks or blocks with outputs only are removed

@romain-grecourt
Copy link
Contributor

What's the impact on the serialized JSON, I don't see any tests. Given that there is a new block type ; the serialized JSON must be impacted too right ? This means that the javascript interpreter will need to be updated.

@tvallin
review changes
06670ff 
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@tvallin tvallin

Labels
archetype enhancement New feature or request OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Archetype: add support for conditional blocks
2 participants
@tvallin @romain-grecourt