Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Incorrect API referenced in metrics doc #2221

Closed
slto opened this issue Jul 29, 2020 · 0 comments · Fixed by #2232
Closed

Doc: Incorrect API referenced in metrics doc #2221

slto opened this issue Jul 29, 2020 · 0 comments · Fixed by #2232
Assignees
Labels
bug Something isn't working docs metrics P2

Comments

@slto
Copy link

slto commented Jul 29, 2020

Environment Details

  • Helidon Version: 2.0.1
  • Helidon SE
  • JDK version: 11.0.8
  • OS: Linux
  • Docker version (if applicable):

Problem Description

The 2.0 metrics documentation on helidon.io site seems incorrect
https://helidon.io/docs/v2/#/se/metrics/01_metrics

It is referencing APIs that don't exists in Helidon 2.0
import io.helidon.metrics.RegistryFactory;
...
private final MetricRegistry registry = RegistryFactory.getRegistryFactory().get()
.getRegistry(MetricRegistry.Type.APPLICATION);

The Helidon SE Metrics Guide uses the correct API
https://helidon.io/docs/v2/#/se/guides/05_metrics

RegistryFactory metricsRegistry = RegistryFactory.getInstance();
MetricRegistry appRegistry = metricsRegistry.getRegistry(MetricRegistry.Type.APPLICATION);

Steps to reproduce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs metrics P2
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants