Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

junit version in microprofile/tests/arquillian/pom.xml is not managed by Helidon #2289

Closed
barchetta opened this issue Aug 26, 2020 · 3 comments · Fixed by #2290
Closed

junit version in microprofile/tests/arquillian/pom.xml is not managed by Helidon #2289

barchetta opened this issue Aug 26, 2020 · 3 comments · Fixed by #2290
Assignees
Labels
2.x Issues for 2.x version branch bug Something isn't working build P3

Comments

@barchetta
Copy link
Member

Reported by David Delabassee:

Btw, I wanted to test Helidon with a snapshot build of Jackson (they just merged Records support).
I updated the Jackson deps but the build fail

[ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for junit:junit:jar is missing. @ io.helidon.microprofile.tests:helidon-arquillian:[unknown-version], /Users/delabassee/Desktop/helidon/microprofile/tests/arquillian/pom.xml, line 64, column 21

It looks like we don't manage the version of junit 4 and we get the version transitively from Jackson. When I generate the effective pom for the pom referenced in the error above I see that the dependencyManagement from Jackson manages the junit 4 version. I assume in David's case the new Jackson version no longer manages the junit 4 version.

@barchetta barchetta added build 2.x Issues for 2.x version branch labels Aug 26, 2020
barchetta added a commit to barchetta/helidon that referenced this issue Aug 26, 2020
@barchetta barchetta added bug Something isn't working P3 labels Aug 26, 2020
@spericas
Copy link
Member

Isn't it coming from arquillian-container-spi?

@barchetta
Copy link
Member Author

barchetta commented Aug 26, 2020

mvn org.apache.maven.plugins:maven-help-plugin:3.2.0:effective-pom -Dverbose shows:

  <dependencyManagement>
    <dependencies>   
. . .
      <dependency>
        <groupId>junit</groupId>  <!-- com.fasterxml.jackson:jackson-parent:2.11, line 76 -->
        <artifactId>junit</artifactId>  <!-- com.fasterxml.jackson:jackson-parent:2.11, line 77 -->
        <version>4.12</version>  <!-- com.fasterxml.jackson:jackson-parent:2.11, line 78 -->
      </dependency>
    </dependencies>
  </dependencyManagement>

This indicates the junit version is coming from Jackson.

@spericas
Copy link
Member

Roger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch bug Something isn't working build P3
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants