You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Helidon 3.x uses the Jaeger OpenTelemetry client to send information to the Jaeger server. That client uses port 14250 (correctly defaulted in the JaegerTracerBuilder class.
We could simply remove the port setting. The default in the code works correctly and the config doc shows port as a config key so readers will know they can override the default if they need to.
Several config keys that we supported in 2.x we no longer support because 3.x uses the OpenTelemetry tracing client rather than the native Jaeger one (as 2.x did). Should the doc contain a brief note at least listing these and/or explaining workarounds if any? For example, propagation is no longer supported, but propagation: b3 is no longer needed because the Helidon's JaegerTracerBuilder class always includes the OpenTelemetry B3Propagator.
The class-level JavaDoc for JaegerTracerBuilder has changed accordingly, but we mention nothing in the doc on our website. See the JaegerTracerBuilder source diffs to see which keys are no longer supported. Here is a copy of the config code that shows which keys were supported in 2.x but not in 3.x:
Enhance the MP QuickStart example by adding the following to microprofile-config.properties: (this came from a user for whom this set-up worked correctly in Helidon 2.x)
tjquinno
changed the title
Doc for Jaeger integration uses incorrect port as of Helidon 3.0
Doc for Jaeger tracing integration uses incorrect port as of Helidon 3.0
Oct 18, 2022
tjquinno
changed the title
Doc for Jaeger tracing integration uses incorrect port as of Helidon 3.0
Doc for Jaeger tracing integration: shows incorrect port as of Helidon 3.0 and maybe should discuss removed config settings
Oct 18, 2022
tjquinno
changed the title
Doc for Jaeger tracing integration: shows incorrect port as of Helidon 3.0 and maybe should discuss removed config settings
Doc for Jaeger tracing integration in 3.x: shows incorrect port as of Helidon 3.0 and maybe should discuss removed config settings
Oct 18, 2022
Environment Details
Problem Description
Helidon 3.x uses the Jaeger OpenTelemetry client to send information to the Jaeger server. That client uses port 14250 (correctly defaulted in the
JaegerTracerBuilder
class.But our doc for Jaeger tracing integration uses port 14240, not 14250 (or leaving it unset to use the correct default). See the config example snippets just below the config tables at https://helidon.io/docs/v3/#/se/tracing#_configuration_options_3 and https://helidon.io/docs/v3/#/mp/tracing#_configuration_options_3.
We could simply remove the port setting. The default in the code works correctly and the config doc shows
port
as a config key so readers will know they can override the default if they need to.Several config keys that we supported in 2.x we no longer support because 3.x uses the OpenTelemetry tracing client rather than the native Jaeger one (as 2.x did). Should the doc contain a brief note at least listing these and/or explaining workarounds if any? For example,
propagation
is no longer supported, butpropagation: b3
is no longer needed because the Helidon'sJaegerTracerBuilder
class always includes the OpenTelemetryB3Propagator
.The class-level JavaDoc for
JaegerTracerBuilder
has changed accordingly, but we mention nothing in the doc on our website. See theJaegerTracerBuilder
source diffs to see which keys are no longer supported. Here is a copy of the config code that shows which keys were supported in 2.x but not in 3.x:Steps to reproduce
Enhance the MP QuickStart example by adding the following to
microprofile-config.properties
: (this came from a user for whom this set-up worked correctly in Helidon 2.x)Start Jaeger (make sure its log reports it is listening on 14250).
Build and run the modified MP QuickStart app.
curl http://localhost:8080/greet
The QuickStart output shows a failure to report the tracing data.
The text was updated successfully, but these errors were encountered: