-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc updates for Jaeger tracing port value #6060
Conversation
Hi @tjquinno - There are a couple of ways to address this doc bug. I believe you were asking the team how to update. Did you get your answer? Should the doc contain a brief note at least listing these and/or explaining workarounds if any? For example, propagation is no longer supported, but propagation: b3 is no longer needed because the Helidon's JaegerTracerBuilder class always includes the OpenTelemetry B3Propagator. |
TBH I am not sure what workarounds, if any, are available for the settings that Jaeger no longer supports. Our config properties, then and now, simply mirror whatever Helidon's code can set on Jaeger's span exporter builder. Jaeger changed and so the settings we can expose changed as well. Given that, it's probably clearer to not list the specific settings we no longer support (given that, at least at the moment, I don't know what, if any, workaround there might be). Maybe, just before the
or something to that effect. |
This commit doesn't include a fix for https://helidon.io/docs/v3/#/se/guides/tracing (the snippet using private void getDefaultMessageHandler refers to and uese the io.opentracing instead of io.helidon.tracing API) |
Hi @al3xandru I'm working with Tim on that. This is still in draft mode until I've completed all of the updates. They will be included in this PR. |
Closing this PR and will include files in a new PR that does not include the generated tracing doc that was accidentally updated. |
Doc for issue #5187 and #6094