Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfiguredOption needs a "Security Sensitive" attribute and it needs to be incorporated into Builder #6908

Closed
trentjeff opened this issue May 25, 2023 · 1 comment
Assignees
Labels
4.x Version 4.x builder Related to the builder support config enhancement New feature or request P3
Milestone

Comments

@trentjeff
Copy link
Member

Considering that we are now using auto-generated Builders, there should be a ConfiguredOption attribute called something like boolean securitySensitive() that can signal to Helidon internals not to display the attribute in things like the toString() output, etc. Note that making the attribute char[] does not help here either since those attributes can still be converted/printed.

Once this option is available it needs to be incorporated into Builder.

Example:

@ConfigBean(OciConfigBean.NAME)
public interface OciConfigBean {

    String NAME = "oci";

    List<String> authStrategies();

    @ConfiguredOption(key = "config.path")
    Optional<String> configPath();

    @ConfiguredOption(key = "config.profile")
    Optional<String> configProfile();

    @ConfiguredOption(key = "auth.fingerprint")
    Optional<String> authFingerprint();

    @ConfiguredOption(key = "auth.passphrase"/*, securitySensitive = true*/)
    Optional<String> authPassphrase();

    @ConfiguredOption(key = "auth.private-key"/*, securitySensitive = true*/)
    Optional<String> authPrivateKey();

    @ConfiguredOption(key = "auth.region")
    Optional<String> authRegion();

    @ConfiguredOption(key = "auth.tenant-id")
    Optional<String> authTenantId();

    @ConfiguredOption(key = "auth.user-id")
    Optional<String> authUserId();
}

@trentjeff trentjeff added enhancement New feature or request config 4.x Version 4.x builder Related to the builder support labels May 25, 2023
@trentjeff trentjeff added this to the 4.x milestone May 25, 2023
@m0mus m0mus added the P3 label Jun 1, 2023
@tomas-langer
Copy link
Member

Fixed by #7008
Added @/Prototype.Confidential annotation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x builder Related to the builder support config enhancement New feature or request P3
Projects
Archived in project
Development

No branches or pull requests

3 participants