New config builders #7008
Merged
New config builders #7008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tomas-langer
force-pushed
the
new-config-builders
branch
from
9a2cae5
to
fe17333
Compare
tomas-langer
requested review from
trentjeff,
romain-grecourt,
danielkec and
Verdent
trentjeff
reviewed
Jun 15, 2023
trentjeff
reviewed
Jun 15, 2023
trentjeff
reviewed
Jun 15, 2023
trentjeff
reviewed
Jun 15, 2023
trentjeff
reviewed
Jun 15, 2023
trentjeff
reviewed
Jun 15, 2023
trentjeff
reviewed
Jun 15, 2023
builder/api/src/main/java/io/helidon/builder/api/Prototype.java
Outdated
Show resolved
Hide resolved
trentjeff
reviewed
Jun 15, 2023
builder/api/src/main/java/io/helidon/builder/api/Prototype.java
Outdated
Show resolved
Hide resolved
builder/api/src/main/java/io/helidon/builder/api/Prototype.java
Outdated
Show resolved
Hide resolved
builder/api/src/main/java/io/helidon/builder/api/Prototype.java
Outdated
Show resolved
Hide resolved
trentjeff
reviewed
Jun 15, 2023
trentjeff
reviewed
Jun 15, 2023
builder/api/src/main/java/io/helidon/builder/api/ProvidedUtil.java
Outdated
Show resolved
Hide resolved
trentjeff
reviewed
Jun 15, 2023
trentjeff
reviewed
Jun 15, 2023
trentjeff
reviewed
Jun 15, 2023
builder/api/src/main/java/io/helidon/builder/api/RuntimeType.java
Outdated
Show resolved
Hide resolved
trentjeff
reviewed
Jun 15, 2023
trentjeff
reviewed
Jun 15, 2023
...der/builder-config-processor/src/main/java/io/helidon/builder/config/processor/Versions.java
Show resolved
Hide resolved
trentjeff
reviewed
Jun 15, 2023
builder/processor/src/main/java/io/helidon/builder/processor/BlueprintProcessor.java
Show resolved
Hide resolved
trentjeff
reviewed
Jun 15, 2023
builder/processor/src/main/java/io/helidon/builder/processor/BlueprintProcessor.java
Outdated
Show resolved
Hide resolved
trentjeff
reviewed
Jun 15, 2023
builder/processor/src/main/java/io/helidon/builder/processor/BlueprintProcessor.java
Show resolved
Hide resolved
trentjeff
reviewed
Jun 15, 2023
builder/processor/src/main/java/io/helidon/builder/processor/CustomMethods.java
Show resolved
Hide resolved
trentjeff
reviewed
Jun 15, 2023
builder/processor/src/main/java/io/helidon/builder/processor/CustomMethods.java
Show resolved
Hide resolved
builder/processor/src/main/java/io/helidon/builder/processor/CustomMethods.java
Show resolved
Hide resolved
builder/processor/src/main/java/io/helidon/builder/processor/FactoryMethods.java
Outdated
Show resolved
Hide resolved
builder/processor/src/main/java/io/helidon/builder/processor/FactoryMethods.java
Outdated
Show resolved
Hide resolved
builder/processor/src/main/java/io/helidon/builder/processor/FactoryMethods.java
Show resolved
Hide resolved
trentjeff
reviewed
Jun 15, 2023
builder/processor/src/main/java/io/helidon/builder/processor/GenerateAbstractBuilder.java
Show resolved
Hide resolved
trentjeff
reviewed
Jun 15, 2023
builder/processor/src/main/java/io/helidon/builder/processor/GenerateAbstractBuilder.java
Show resolved
Hide resolved
trentjeff
reviewed
Jun 15, 2023
builder/processor/src/main/java/io/helidon/builder/processor/GenerateAbstractBuilder.java
Show resolved
Hide resolved
…lueprints. Also added a few missing `@Contract`
Use inner types for all things related to `Prototype` and `RuntimeType` toString method now separates types with a semicolon Use `clear` instead of `unset` for clearing optional values
tomas-langer
force-pushed
the
new-config-builders
branch
from
6ddfd9e
to
8381681
Compare
trentjeff
reviewed
Jun 22, 2023
trentjeff
approved these changes
Jun 22, 2023
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Helidon to provide support for (simplified) builders
Update to config driven to simplify it
Changes to pico and all related components to use (more)
TypeNameand new builder approach.Force pushed with better commit structure.
Discovered my first build missed a few integration tests, fixing now.
20230616 - Pushed fixes of integration tests
List of follow ups: #7023
A problem discussed on this PR that requires more design: #7052
Also resolves:
#6566
#6719 - first step
#6908
#6947