Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jersey 2.29.1 #1010

Merged
merged 3 commits into from
Sep 10, 2019
Merged

Conversation

tomas-langer
Copy link
Member

Signed-off-by: Tomas Langer tomas.langer@oracle.com

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer self-assigned this Sep 10, 2019
@tomas-langer tomas-langer added jax-rs JAX-RS and Jersey related issues P1 labels Sep 10, 2019
@tomas-langer
Copy link
Member Author

Resolves #882

@tomas-langer tomas-langer requested review from spericas and batsatt and removed request for barchetta September 10, 2019 20:03
@tomas-langer
Copy link
Member Author

Latest version fixes:

  • adds REST Client 1.3
  • adds new version of hk2 with a performance bug fixed

spericas
spericas previously approved these changes Sep 10, 2019
batsatt
batsatt previously approved these changes Sep 10, 2019
@romain-grecourt
Copy link
Contributor

The pipeline build has the following error during the open-api tck:

Caused by: java.lang.NoSuchMethodError: 'java.lang.String org.eclipse.microprofile.rest.client.inject.RegisterRestClient.configKey()'
	at org.glassfish.jersey.microprofile.restclient.RestClientProducer.<init>(RestClientProducer.java:108)
	at org.glassfish.jersey.microprofile.restclient.RestClientExtension.lambda$restClientRegistration$0(RestClientExtension.java:81)
	at java.base/java.lang.Iterable.forEach(Iterable.java:75)
	at org.glassfish.jersey.microprofile.restclient.RestClientExtension.restClientRegistration(RestClientExtension.java:81)

@tomas-langer
Copy link
Member Author

There are two problems

  1. wrong version of MP Rest Client (easy to fix)
  2. TCK for MP Rest Client do not pass in Helidon (need to investigate)

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer dismissed stale reviews from batsatt and spericas via 981a5ff September 10, 2019 20:50
batsatt
batsatt previously approved these changes Sep 10, 2019
@tomas-langer
Copy link
Member Author

The problem is in loading resources from the classpath by integration with Arquillian.
There is a resource path "/META-INF/..." - it does not work in Helidon TCK tests (would work without the leading slash).
I consider this a problem with our integration for now: will look deeper into this tomorrow

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Copy link
Member Author

Workaround to accept resource path starting with / - this works fine outside of Heildon Arquillian container, so fixed it so tests pass

@romain-grecourt romain-grecourt merged commit 11e0c5b into helidon-io:master Sep 10, 2019
@tomas-langer tomas-langer deleted the jersey-2-29-1 branch January 31, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jax-rs JAX-RS and Jersey related issues P1
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants