Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly stop wiremock after rest-client tcks #1939

Merged
merged 6 commits into from
Jun 7, 2020

Conversation

danielkec
Copy link
Contributor

@danielkec danielkec commented Jun 6, 2020

  • Bump wiremock maven plugin to version which supports stop goal
  • Switch from MultiFromOutputStream to IoMulti
  • Fix javadoc
  • Add module-info

see ipastusi/wiremock-maven-plugin/issues/10

Signed-off-by: Daniel Kec daniel.kec@oracle.com

  * Bump wiremock maven plugin to version which supports stop goal

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec self-assigned this Jun 6, 2020
@danielkec danielkec added build dependencies Pull requests that update a dependency file labels Jun 6, 2020
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>

Javadoc fix

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>

Revert "Javadoc fix"

This reverts commit 571bf3d8

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>

Copyright fix

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielkec danielkec merged commit ab6d173 into helidon-io:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants