Initial revision of Loom experiments #2224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace to trigger it Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
|
This (currently draft) PR is related to #1412. |
tomas-langer
reviewed
Aug 3, 2020
| jaxRsExecutorService = ServerThreadPoolSupplier.builder() | ||
| Config serverConfig = config.get("server"); | ||
| final java.lang.reflect.Method m; | ||
| if (serverConfig.get("virtual-threads").asBoolean().isPresent()) { |
There was a problem hiding this comment.
asBoolean().orElse(false) - what if virtual-threads: false - you would execute as well
There was a problem hiding this comment.
Yep; just a dumb typo in this draft PR
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
|
I removed my fork at one point so I'm going to close this and re-roll it with substantially the same changes. |
|
Closing; watch for the new one! |
|
See #2417 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the config stuff to trigger it; more commits to follow. The intent is that you can check this PR out and it will still build and run if you have JDK 11 but will be capable of being run under a Loom early build.
Signed-off-by: Laird Nelson laird.nelson@oracle.com