Integrate build-tools 2.1.1 #2314
Conversation
| @@ -13,8 +13,9 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
| # | |||
| build-tools.version={{buildtoolsVersion}} | |||
| build-tools.version=2.0.2 | |||
There was a problem hiding this comment.
Seems to be the wrong version here, shouldn't this be the placeholder?
There was a problem hiding this comment.
Romain said this was intentional as it was "the version of the helidon-maven-plugin that contains the goal “dev” before we split it into helidon-cli-maven-plugin". And that this is used only for testing. We might want to follow-up on this, but I don't think it should block the PR.
There was a problem hiding this comment.
This property is correct. It corresponds to the older version of helidon-maven-plugin that contained the goal dev, it is used for backward compatibility. Also note that this file is only used for testing.
| cli.version={{cliVersion}} | ||
| {{#cliUpdateMessages}} | ||
| cli.{{version}}.message={{message}} | ||
| cli.{{version}}.message={{message}} |
There was a problem hiding this comment.
Is the whitespace intentional?
There was a problem hiding this comment.
Yes, this is a mustache loop ; thus the indentation.
| @@ -120,6 +120,8 @@ | |||
| <version.plugin.wiremock>2.14.0</version.plugin.wiremock> | |||
| <version.plugin.echo>0.4.0</version.plugin.echo> | |||
|
|
|||
| <version.helidon-cli>2.1.0</version.helidon-cli> | |||
There was a problem hiding this comment.
Is the cli released separately? If not, this should be the same version as build-tools
There was a problem hiding this comment.
No change was made to the CLI plugin, so he left this version the same.
There was a problem hiding this comment.
The CLI wasn't released as part of 2.1.1 because no changes were made to the CLI ; thus the difference in versions.
|
This PR is needed for |
No description provided.