-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PostgreSQL driver support for JPA/Hibernate in native image #2596
Conversation
First waiting for native image tests to finish. edit: 1st run contained test errors to verify whether tests will fail. This worked fine so now scripts were modified to contain proper targets only. |
@barchetta This is currently blocked by 3rd party approval so adding you as reviewer. Please let us know whether it is moving forward somehow. |
@romain-grecourt One of the tests failed during native image build. This is quite strange, because it's not usually happening. I saw it for the first time here. Do you have any idea what's going wrong? Is it resources (memory, disk space) problem? |
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
2352170
to
4b7367e
Compare
I had to remove parallel jobs from Jenkinsfile in master because of resource issues. This PR was rebased and squashed to resolve conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving third party dependencies.
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the changes for mysql are required as part of this PR, it can be merged.
@@ -52,8 +52,12 @@ mvn ${MAVEN_ARGS} -f ${WS_DIR}/pom.xml \ | |||
|
|||
# Run tests in Java VM application | |||
(cd tests/integration/jpa && \ | |||
mvn ${MAVEN_ARGS} clean verify -Dmysql) | |||
mvn ${MAVEN_ARGS} clean verify \ | |||
-Dmaven.test.failure.ignore=true -Dmysql \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong - this PR is for psql
not for mysql
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was -Dmaven.test.failure.ignore=true missing so I added it into both scripts. They are not being used now and we'll do another review after Romain prepares parallel jobs setup for all those native image integration tests.
@@ -0,0 +1,63 @@ | |||
#!/bin/bash -ex | |||
# | |||
# Copyright (c) 2018, 2020 Oracle and/or its affiliates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright is wrong (as with other new files in this PR) - the year should be just 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's copy-paste. I'll fix it in next PR.
To run the tests, build Helidon and then execute: