-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples: multiple ports #2834
Examples: multiple ports #2834
Conversation
...es/microprofile/multiport/src/main/java/io/helidon/examples/microprofile/multiport/Main.java
Outdated
Show resolved
Hide resolved
examples/webserver/multiport/src/main/resources/application.yaml
Outdated
Show resolved
Hide resolved
examples/microprofile/multiport/src/main/resources/application.yaml
Outdated
Show resolved
Hide resolved
...ofile/multiport/src/main/java/io/helidon/examples/microprofile/multiport/PublicResource.java
Outdated
Show resolved
Hide resolved
I came at this by considering how a user might convert our classic MP greeting app to use multiple routing names. First choice: add
|
@tjquinno I experimented with those first two options as well with the same results. |
@barchetta It might be worth seeing if the |
...icroprofile/multiport/src/test/java/io/helidon/examples/microprofile/multiport/MainTest.java
Show resolved
Hide resolved
...ples/webserver/multiport/src/test/java/io/helidon/examples/webserver/multiport/MainTest.java
Outdated
Show resolved
Hide resolved
...ples/webserver/multiport/src/test/java/io/helidon/examples/webserver/multiport/MainTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add some additional negative-expected probes? Otherwise LGTM.
...icroprofile/multiport/src/test/java/io/helidon/examples/microprofile/multiport/MainTest.java
Show resolved
Hide resolved
...icroprofile/multiport/src/test/java/io/helidon/examples/microprofile/multiport/MainTest.java
Show resolved
Hide resolved
microprofile/server/src/main/java/io/helidon/microprofile/server/ServerCdiExtension.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please see the comment
* Add multiple port examples for WebServer and MicroProfile
* Add multiple port examples for WebServer and MicroProfile
Fixes #2815
Also adds
int port(String name)
toServerCdiExtension