Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly destroy bean instance obtained from CDI object #3214

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

spericas
Copy link
Member

Explicitly destroy bean instance obtained from CDI object that is not in a normal scope. Not manually destroying these instances resulted in the context' map monotonically growing in size. See analysis and description in Issue #3199.

Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com

… in a normal scope. Not manually destroying these instances resulted in the context' map monotonically growing in size as described in Issue helidon-io#3199.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@spericas spericas merged commit 75846f5 into helidon-io:master Jul 23, 2021
spericas added a commit to spericas/helidon that referenced this pull request Aug 16, 2021
… in a normal scope. Not manually destroying these instances resulted in the context' map monotonically growing in size as described in Issue helidon-io#3199. (helidon-io#3214)

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
(cherry picked from commit 75846f5)
spericas added a commit that referenced this pull request Aug 16, 2021
… in a normal scope. Not manually destroying these instances resulted in the context' map monotonically growing in size as described in Issue #3199. (#3214)

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
(cherry picked from commit 75846f5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants