Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move scheduling of metrics periodic updater so it is run in MP as well as in SE (3.x) #3733

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Move scheduling of metrics periodic updater so it is run in MP as well as in SE (3.x) #3733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions metrics/metrics/src/main/java/io/helidon/metrics/MetricsSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,8 @@ protected void postConfigureEndpoint(Routing.Rules defaultRules, Routing.Rules s
io.helidon.metrics.RegistryFactory fullRF = (io.helidon.metrics.RegistryFactory) rf;
Registry app = fullRF.getARegistry(MetricRegistry.Type.APPLICATION);

PeriodicExecutor.start();

// register the metric registry and factory to be available to all
MetricsContextHandler metricsContextHandler = new MetricsContextHandler(app, rf);
defaultRules.any(metricsContextHandler);
Expand Down Expand Up @@ -468,8 +470,6 @@ private void setUpFullFeaturedEndpoint(Routing.Rules serviceEndpointRoutingRules
*/
@Override
public void update(Routing.Rules rules) {
PeriodicExecutor.start();

configureEndpoint(rules, rules);
}

Expand Down