Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load both bean definitions of the same type instead of choosing just one #4494

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Load both bean definitions of the same type instead of choosing just one #4494

merged 1 commit into from
Jul 8, 2022

Conversation

klustria
Copy link
Member

@klustria klustria commented Jul 8, 2022

Notes:

  1. TestMicronautBean has 2 bean definitions and both needs to be loaded. This behaviour is the same as in v2.5.1.
  2. Add hashcode on the return value of overridden MicronautBean.toString to make it unique.

@klustria
Load both bean definitions of the same type instead of choosing just …
0fb7882 
…one.

Notes:
1. TestMicronautBean has 2 bean definitions and both needs to be loaded. This behaviour is the same as in v2.5.1.
2. Add hashcode on the return value of overridden MicronautBean.toString to make it unique.
@klustria klustria mentioned this pull request Jul 8, 2022
Closed
@klustria
Copy link
Member Author

klustria commented Jul 8, 2022

This PR will knock off a couple of TODO task related to the issue this is fixing in #4411

@klustria klustria merged commit ffc63e7 into helidon-io:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klustria @tomas-langer