Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt review comments on doc updates #4627

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Adopt review comments on doc updates #4627

merged 2 commits into from
Aug 9, 2022

Conversation

tjquinno
Copy link
Member

Resolves #4626

@tjquinno tjquinno requested a review from ljamen July 27, 2022 18:38
@tjquinno tjquinno self-assigned this Jul 27, 2022
@tjquinno
Copy link
Member Author

tjquinno commented Aug 4, 2022

/trigger

ljamen
ljamen previously approved these changes Aug 8, 2022
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, thank you.

@barchetta barchetta changed the base branch from master to helidon-3.x August 8, 2022 21:57
@barchetta barchetta dismissed ljamen’s stale review August 8, 2022 21:57

The base branch was changed.

@tjquinno tjquinno merged commit af86030 into helidon-io:helidon-3.x Aug 9, 2022
tjquinno added a commit to tjquinno/helidon that referenced this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise various doc updates (metrics, OpenAPI) based on review comments
3 participants