4184 logging for an MP app #4903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tjquinno could you please have a look) |
tjquinno
requested changes
Sep 20, 2022
There was a problem hiding this comment.
Sorry for the delay in getting to this.
It seems that the SE and MP content are almost identical. (The format of the access log config examples is understandably different.)
Our maintenance job would be easier if the common content were refactored into a separate file and then that file included into each of these two pages.
Also, this is perhaps outside the scope of this issue and PR, but the AccessLogSupport.Builder class and methods should be annotated with @Configured and @ConfiguredOption and the generated file included in these pages.
|
tjquinno
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access log documentation fix
Resolves #4184