Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Github pipeline more robust by increasing HTTP ttl and adding a retry #5164

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Make Github pipeline more robust by increasing HTTP ttl and adding a retry #5164

merged 3 commits into from
Oct 12, 2022

Conversation

spericas
Copy link
Member

Make Github pipeline more robust by increasing HTTP ttl and adding a retry.

Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com

@spericas
Make Github pipeline more robust by increasing HTTP ttl and adding a …
f9ac425 
…retry.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas added build 4.x Version 4.x labels Oct 12, 2022
@spericas spericas added this to the 4.0.0 milestone Oct 12, 2022
@spericas spericas self-assigned this Oct 12, 2022
tomas-langer
tomas-langer reviewed Oct 12, 2022
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples job uses mvn command directly. Maybe this should be added to the validate.yml file as a property and used both in the scripts and in the job (see env at the beginning of the workflow).

@spericas
Copy link
Member Author

For what is worth, there were no retries needed for this PR

@spericas
Attempt to move maven HTTP args to pipeline file.
bdd0a57 
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas
Removed curly braces.
9c74904 
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas merged commit cf3e2fe into helidon-io:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees

@spericas spericas

Labels
4.x Version 4.x build
Projects
Backlog
Archived in project
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@spericas @tomas-langer