Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP on Níma #5176

Merged
merged 11 commits into from
Oct 14, 2022
Merged

MP on Níma #5176

merged 11 commits into from
Oct 14, 2022

Conversation

tomas-langer
Copy link
Member

@tomas-langer tomas-langer commented Oct 14, 2022

MicroProfile running on Níma server.
There are a few things disabled to be fixed later, I will create follow up issues:

  • OIDC support now has both (WebServer and Níma)
  • MP Fault tolerance still based on reactive FT
  • microprofile/pom.xml - websocket is commented out
  • examples/messaging/pom.xml (websocket)
  • examples/microprofile/pom.xml (websocket)
  • MicroMeter combines reactive and Níma in same module
  • microprofile/tests/tck/pom.xml
    tck-metrics commented out
    tck-jwt-auth commented out
    tck-opentracing commented out
    tck-lra commented out
  • microprofile/tracing/src/main/java/io/helidon/microprofile/tracing/TracingCdiExtension.java - no WebTracingConfig

Disabled:
grpc/metrics/src/test/java/io/helidon/grpc/metrics/GrpcMetricsInterceptorIT.java
grpc/metrics/src/test/java/io/helidon/grpc/metrics/MetricsIT.java
microprofile/cors/src/test/java/io/helidon/microprofile/cors/AdapterTest.javad
microprofile/metrics/src/test/java/io/helidon/microprofile/metrics/TestDisabledMetrics.java
microprofile/metrics/src/test/java/io/helidon/microprofile/metrics/TestExtendedKPIMetrics.java
microprofile/metrics/src/test/java/io/helidon/microprofile/metrics/TestMetricsOnOwnSocket.java
microprofile/server/src/test/java/io/helidon/microprofile/server/JerseyPropertiesTest.java
microprofile/server/src/test/java/io/helidon/microprofile/server/ServerSseTest.java
nima/openapi/src/test/java/io/helidon/nima/openapi/ServerTest.java
nima/openapi/src/test/java/io/helidon/nima/openapi/TestCors.java
reactive/openapi/src/test/java/io/helidon/reactive/openapi/ServerModelReaderTest.java
reactive/openapi/src/test/java/io/helidon/reactive/openapi/TestCors.java
tests/functional/bookstore/src/test/java/io/helidon/tests/bookstore/MainTest.java
tests/functional/request-scope/src/test/java/io/helidon/tests/functional/requestscope/TenantTest.java
tests/integration/mp-gh-3974/src/test/java/io/helidon/tests/integration/gh3974/Gh3974Test.java
removed: assertThat("Response entity should not be an empty string", response.readEntity(String.class), not(""));
tests/integration/mp-ws-services/src/test/java/io/helidon/tests/integration/mp/ws/services/MpServicesTest.java
testJaxrs() -> application is not available on configured socket
tests/integration/security/path-params/src/test/java/io/helidon/tests/integration/security/pathparams/AdminTest.java

tomas-langer and others added 7 commits October 14, 2022 11:28
Refactored all usages.
Initial switch to Níma in MP
refactored for Níma, SE and MP
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
spericas
spericas previously approved these changes Oct 14, 2022
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went over it quickly. IMO this sort of PR does not need to be perfect. We should merge it as soon as the pipeline passes for future work to be possible.

@tomas-langer
Copy link
Member Author

I am working on fixes of packaging. Getting there (discovered a bug in Jersey integration)

@tomas-langer tomas-langer merged commit 179b5ad into helidon-io:main Oct 14, 2022
@tomas-langer tomas-langer deleted the 5056-mp-on-nima branch October 14, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants