Issue 5416: Transfer configuration to connection providers. #5682
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
|
This is actually still work in progress. I just need some feedback from @tomas-langer |
Tomas-Kraus
force-pushed
the
issue-5416
branch
from
ecf6c8b
to
ac5ee78
Compare
nima/http2/webserver/src/main/java/io/helidon/nima/http2/webserver/Http2Config.java
Outdated
Show resolved
Hide resolved
nima/http2/webserver/src/main/java/io/helidon/nima/http2/webserver/Http2ConnectionProvider.java
Show resolved
Hide resolved
...ebserver/webserver/src/main/java/io/helidon/nima/webserver/spi/ServerConnectionProvider.java
Show resolved
Hide resolved
nima/http2/webserver/src/main/java/io/helidon/nima/http2/webserver/Http2Connection.java
Outdated
Show resolved
Hide resolved
|
|
||
| // Builds LoomServer instance including connectionProviders list. | ||
| WebServer.Builder wsBuilder = WebServer.builder() | ||
| .config(config.get("server")); |
There was a problem hiding this comment.
If you want to check that the configuration was propagated, you can have static methods on your custom connection provider, build the server, and then check that your connection provider obtained the correct setup.
There was a problem hiding this comment.
Well, yes, that's 1st part of the test. But it's not enough.
I would also like to know that those specific 2 values described in the issue got propagated into local Http2Settings instance of the Http2Connection.
| .config(config.get("server")); | ||
|
|
||
| // Call wsBuilder.connectionProviders() trough reflection | ||
| Method connectionProviders = WebServer.Builder.class.getDeclaredMethod("connectionProviders",null); |
There was a problem hiding this comment.
This is very hard to maintain, as it escapes refactoring.
There was a problem hiding this comment.
Unfortunately onnectionProviders() is not in the same package here. Theoretically I can create accessor in in tests of WebServer module where there is no problem to have the same package in the tests.
nima/webserver/webserver/src/main/java/io/helidon/nima/webserver/WebServer.java
Outdated
Show resolved
Hide resolved
Tomas-Kraus
force-pushed
the
issue-5416
branch
2 times, most recently
from
dd41723
to
17d98ab
Compare
Tomas-Kraus
force-pushed
the
issue-5416
branch
from
9c35da8
to
e48f502
Compare
|
All builds/tests are finally green. Let's do final review & merge. |
Tomas-Kraus
force-pushed
the
issue-5416
branch
from
e48f502
to
2185849
Compare
|
Rebase to check whether copyrights are ok on 2023. |
Tomas-Kraus
force-pushed
the
issue-5416
branch
2 times, most recently
from
025cf9d
to
edc8a72
Compare
Tomas-Kraus
force-pushed
the
issue-5416
branch
from
edc8a72
to
e7d7992
Compare
Tomas-Kraus
force-pushed
the
issue-5416
branch
from
e7d7992
to
a921b8d
Compare
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Tomas-Kraus
force-pushed
the
issue-5416
branch
from
a921b8d
to
8577b6d
Compare
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
|
Closing this PR, replaced by #5883 |
Signed-off-by: Tomáš Kraus tomas.kraus@oracle.com