Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5409 duration timeout #5709

Merged
merged 16 commits into from
Dec 23, 2022
Merged

5409 duration timeout #5709

merged 16 commits into from
Dec 23, 2022

Conversation

aserkes
Copy link
Contributor

@aserkes aserkes commented Dec 16, 2022

Use Duration for our timeouts

Fixes #5409

I found other places where timeouts were used, but I am not sure do we really need to add methods that accepts Duration overthere. Usually in these places information about timeouts stored in long or int fields which store duration of timeout in milliseconds and these fields are not used overthere to instantiate Duration instances :

  • io.helidon.reactive.webserver.SocketConfiguration
  • io.helidon.reactive.webserver.ServerConfiguration.Builder.timeout(long, java.util.concurrent.TimeUnit)
  • io.helidon.reactive.webserver.WebServer.Builder.timeout
  • io.helidon.reactive.webserver.WebServerTls.Builder.sessionTimeout
  • io.helidon.security.providers.httpauth.HttpDigestAuthProvider.Builder.digestNonceTimeout
  • io.helidon.reactive.webserver.WebServerTls.Builder.sessionTimeout
  • io.helidon.security.providers.common.EvictableCache.Builder.timeout
  • io.helidon.security.providers.common.EvictableCache.Builder.overallTimeout

@aserkes aserkes self-assigned this Dec 16, 2022
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 16, 2022
Signed-off-by: aserkes <andrii.serkes@oracle.com>
@aserkes aserkes marked this pull request as draft December 16, 2022 10:14
@aserkes aserkes marked this pull request as ready for review December 16, 2022 11:25
Signed-off-by: aserkes <andrii.serkes@oracle.com>
@tomas-langer
Copy link
Member

Please rebase on latest main, the intermittent test failure should no longer happen in WebServer

Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All deprecations should be done with what I described in the first comment.

@aserkes aserkes force-pushed the 5409_duration_timeout branch 2 times, most recently from 1afe8f7 to 2e93169 Compare December 21, 2022 09:47
Signed-off-by: aserkes <andrii.serkes@oracle.com>
Signed-off-by: aserkes <andrii.serkes@oracle.com>
@aserkes aserkes merged commit 3e93881 into helidon-io:main Dec 23, 2022
@aserkes aserkes deleted the 5409_duration_timeout branch December 23, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants