[main] Issue 5383: ContentEncodingContext Builder and passing ContentEncodingContext instance from WebServer to Http1Connection. #5921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Required
oracle-contributor-agreement
bot
added
OCA Verified
tomas-langer
requested changes
Jan 20, 2023
...tp/encoding/encoding/src/main/java/io/helidon/nima/http/encoding/ContentEncodingContext.java
Outdated
Show resolved
Hide resolved
...tp/encoding/encoding/src/main/java/io/helidon/nima/http/encoding/ContentEncodingContext.java
Outdated
Show resolved
Hide resolved
...tp/encoding/encoding/src/main/java/io/helidon/nima/http/encoding/ContentEncodingContext.java
Outdated
Show resolved
Hide resolved
tomas-langer
requested changes
Jan 30, 2023
...tp/encoding/encoding/src/main/java/io/helidon/nima/http/encoding/ContentEncodingContext.java
Outdated
Show resolved
Hide resolved
nima/webserver/webserver/src/main/java/io/helidon/nima/webserver/WebServer.java
Show resolved
Hide resolved
…gContext instance from WebServer to Http1Connection. Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
… from server config Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
…nection-providers and content-encoding nodes. Added jUnits to verify config options. Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Tomas-Kraus
force-pushed
the
issue-5383
branch
from
8d3f6c3
to
d535340
Compare
tomas-langer
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
ContentEncodingSupport.Builderand removed static content.ContentEncodingContextinHttp1Connectionis taken fromctx.serverContext()instead of creating a new instance.