Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UriQuery should not support null parameters. #5950

Merged
merged 1 commit into from
Jan 24, 2023
Merged

UriQuery should not support null parameters. #5950

merged 1 commit into from
Jan 24, 2023

Conversation

tomas-langer
Copy link
Member

Fixed TyrusUpgrader which was not thread safe.

@tomas-langer
UriQuery should not support null parameters.
cd90a52 
Fixed TyrusUpgrader which was not thread safe.
@tomas-langer tomas-langer added websocket WebSocket in Helidon common 4.x Version 4.x labels Jan 24, 2023
@tomas-langer tomas-langer self-assigned this Jan 24, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 24, 2023
@tomas-langer tomas-langer added this to the 4.0.0-ALPHA4 milestone Jan 24, 2023
tjquinno
tjquinno approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly the UriQuery changes look good to me. I am less familiar with the other affected files.

spericas
spericas approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@tomas-langer tomas-langer merged commit 39b0c39 into helidon-io:main Jan 24, 2023
@tomas-langer tomas-langer deleted the 5949-uri-query branch January 24, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spericas spericas spericas approved these changes

@tjquinno tjquinno tjquinno approved these changes

Assignees

@tomas-langer tomas-langer

Labels
4.x Version 4.x common OCA Verified All contributors have signed the Oracle Contributor Agreement. websocket WebSocket in Helidon
Projects
None yet
Milestone
4.0.0-ALPHA4
Development

Successfully merging this pull request may close these issues.
3 participants
@tomas-langer @spericas @tjquinno