Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Configuration fixes #6145

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Conversation

tomas-langer
Copy link
Member

@tomas-langer tomas-langer commented Feb 10, 2023

Resolves #6102

  • allow unresolved key references (configurable)
  • config created from another config honors node types
  • added Config.Builder methods to control "fail on missing reference" behavior for both key resolving and value resolving
  • defaults are now aligned for key and value reference resolving - not to fail on missing reference

- allow unresolved key references (configurable)
- config created from another config honors node types
@tomas-langer tomas-langer added bug Something isn't working config 4.x Version 4.x labels Feb 10, 2023
@tomas-langer tomas-langer self-assigned this Feb 10, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 10, 2023
@tomas-langer tomas-langer changed the title Configuration fixes: 4.x: Configuration fixes Feb 10, 2023
@tjquinno
Copy link
Member

A developer should be able to set the fail-on-missing-key-reference behavior programmatically as well as in the config file.

… - aligned with value resolving filter

Builder methods added for key resolving and value resolving "fail on missing reference"
@tomas-langer tomas-langer merged commit aa26ec8 into helidon-io:main Feb 10, 2023
@tomas-langer tomas-langer deleted the 6102-config-ref branch February 10, 2023 17:29
tomas-langer added a commit to tomas-langer/helidon that referenced this pull request Feb 10, 2023
* Configuration fixes:
- allow unresolved key references (configurable)
- config created from another config honors node types
- Key resolving does not fail by default when reference cannot be found - aligned with value resolving filter
- Config.Builder methods added for key resolving and value resolving "fail on missing reference"

(cherry picked from commit aa26ec8)
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
barchetta pushed a commit that referenced this pull request Feb 10, 2023
* 4.x: Configuration fixes (#6145)
- allow unresolved key references (configurable)
- config created from another config honors node types
- Key resolving does not fail by default when reference cannot be found - aligned with value resolving filter
- Config.Builder methods added for key resolving and value resolving "fail on missing reference"
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer added a commit to tomas-langer/helidon that referenced this pull request Feb 12, 2023
- allow unresolved key references (configurable)
- config created from another config honors node types
- Key resolving does not fail by default when reference cannot be found - aligned with value resolving filter
- Config.Builder methods added for key resolving and value resolving "fail on missing reference"

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@sullis sullis mentioned this pull request Feb 13, 2023
tomas-langer added a commit that referenced this pull request Feb 13, 2023
* 2.x: Configuration fixes (#6145) (#6150)
- allow unresolved key references (configurable)
- config created from another config honors node types
- Key resolving does not fail by default when reference cannot be found - aligned with value resolving filter
- Config.Builder methods added for key resolving and value resolving "fail on missing reference"
- Fixed switch statement, too new java feature...

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x bug Something isn't working config OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants