Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nima Quickstart Archetype #6229

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Nima Quickstart Archetype #6229

merged 2 commits into from
Feb 22, 2023

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Feb 16, 2023

fix #5942

@tvallin tvallin added archetypes 4.x Version 4.x labels Feb 16, 2023
@tvallin tvallin self-assigned this Feb 16, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 16, 2023
barchetta
barchetta reviewed Feb 16, 2023
View reviewed changes
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a try and it works! Good start. A few things:

  1. README: it states Java17+. Should be Java19+. I assume that is in a common file
  2. README: java -jar command needs --enable-preview. You can go ahead and add that in common as well since MP now needs it and it does not hurt SE (which might need it at some point)
  3. README: it's missing instructions on how to exercise the application. Maybe because missing custom? which brings me to...

I see there is no "custom" choice for nima apptype. I wonder if we should go ahead and create one even if it is not very featureful at first -- like maybe just json provider? This is to implement our design pattern even if it is not fully fleshed out yet.

@tvallin
Nima Quickstart Archetype
192a489 
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin
review changes
8e602e9 
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin
Copy link
Member Author

tvallin commented Feb 17, 2023

The README can be modified without the custom (see latest commit). I think we can create a new issue for custom and make the changes there based on what features will be provided by custom. This way, quickstart is ready for next release thanks to this PR, and custom can have more features available than media for instance.

@barchetta barchetta mentioned this pull request Feb 17, 2023
Closed
@barchetta
Copy link
Member

I have created issue #6243 to track second phase of work.

@tvallin
Copy link
Member Author

tvallin commented Feb 20, 2023

@romain-grecourt would you like to have a look at it before merging ?

@barchetta barchetta merged commit 397f711 into helidon-io:main Feb 22, 2023
@tvallin tvallin deleted the nima_archetype branch February 23, 2023 08:10
@tvallin tvallin mentioned this pull request Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt approved these changes

@barchetta barchetta barchetta approved these changes

Assignees

@tvallin tvallin

Labels
4.x Version 4.x archetypes OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvallin @barchetta @romain-grecourt