Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 5383: Added Content-Encoding header check when content encoding is disabled. #6267

Merged
merged 5 commits into from
Mar 9, 2023
Merged

Issue 5383: Added Content-Encoding header check when content encoding is disabled. #6267

merged 5 commits into from
Mar 9, 2023

Conversation

Tomas-Kraus
Copy link
Member

Just simple TODO implementation.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Feb 22, 2023
@Tomas-Kraus Tomas-Kraus linked an issue Feb 22, 2023 that may be closed by this pull request
Nima: Http1Connection #5383
Closed
@Tomas-Kraus Tomas-Kraus changed the base branch from helidon-3.x to main February 22, 2023 12:31
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Feb 22, 2023
@Tomas-Kraus
Copy link
Member Author

This seems to be last TODO in Http1Connection so I linked issue #5383 here to be closed with the merge.

@Tomas-Kraus Tomas-Kraus self-assigned this Feb 22, 2023
@Tomas-Kraus Tomas-Kraus marked this pull request as draft February 22, 2023 12:42
@Tomas-Kraus Tomas-Kraus marked this pull request as ready for review February 22, 2023 12:42
@Tomas-Kraus
Issue 5383: Added Content-Encoding header check when content encoding…
6759c6a 
… is disabled

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
@Tomas-Kraus
Issue 5383: Added test to verify proper response under conditions tha…
7eb0b86 
…t trigger newly added exception.

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
@Tomas-Kraus
Issue 5383: Added headers validation trigger and additional test.
10df78e 
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
@Tomas-Kraus
Issue 5383: Fixed imports.
5a59ee6 
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
@Tomas-Kraus
Issue 5383: Review notes aplpied.
3939e5f 
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
@Tomas-Kraus
Copy link
Member Author

Rebased on top of the main branch.

spericas
spericas approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tomas-Kraus Tomas-Kraus merged commit d0674b5 into helidon-io:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spericas spericas spericas approved these changes

@danielkec danielkec Awaiting requested review from danielkec

Assignees

@Tomas-Kraus Tomas-Kraus

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nima: Http1Connection
2 participants
@Tomas-Kraus @spericas