Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCK Tracking: Jakarta EE 10 Core Profile #6799 #6885

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented May 23, 2023

Relates to #6799

Some TCK tests are excluded in restfull and cdi. You can see them with a <!-- FIXME: Next tests must be enabled --> in the pom file. I will create a new issue to address that.

URL of the TCKS:
https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/promoted/eftl/

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 23, 2023
@jbescos jbescos marked this pull request as draft May 23, 2023 07:17
@jbescos jbescos force-pushed the issue6799 branch 2 times, most recently from d4388af to f0575ea Compare May 29, 2023 13:46
@jbescos jbescos force-pushed the issue6799 branch 18 times, most recently from b544b81 to 2137152 Compare June 7, 2023 11:46
@jbescos jbescos force-pushed the issue6799 branch 4 times, most recently from bc398bc to 56ac1ee Compare June 9, 2023 09:33
@jbescos jbescos marked this pull request as ready for review June 9, 2023 10:08
@jbescos jbescos force-pushed the issue6799 branch 3 times, most recently from b2a3cb1 to a43f028 Compare June 14, 2023 09:49
@jbescos jbescos force-pushed the issue6799 branch 2 times, most recently from 4a370f1 to 2fdbf2c Compare June 26, 2023 05:32
@jbescos jbescos marked this pull request as ready for review July 17, 2023 15:48
@jbescos jbescos force-pushed the issue6799 branch 5 times, most recently from e410f16 to b1d4d2a Compare July 18, 2023 13:22
@jbescos
Copy link
Member Author

jbescos commented Jul 19, 2023

This PR is ready for review.

Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few .sh files in the PR, with no explanation in a README.md or simillar - do we need those files? If we do, why and how should we use them?
Any shell script is a danger for us - we need to maintain them, and if called from aynwhere in maven (or ant that was added), it may do things that are unexpected.

dependencies/pom.xml Outdated Show resolved Hide resolved
dependencies/pom.xml Outdated Show resolved Hide resolved
microprofile/tests/tck/pom.xml Outdated Show resolved Hide resolved
microprofile/tests/tck/tck-restfull/artifact-install.sh Outdated Show resolved Hide resolved
@jbescos
Copy link
Member Author

jbescos commented Aug 8, 2023

There are a few .sh files in the PR, with no explanation in a README.md or simillar - do we need those files? If we do, why and how should we use them? Any shell script is a danger for us - we need to maintain them, and if called from aynwhere in maven (or ant that was added), it may do things that are unexpected.

These sh and ant scripts exists because TCK artifacts don't exist in any maven repository. They submit a zip file with the jars, and sometimes there is an SH file to install dependencies.
In some zip files the SH file is missing. To be consistent with the other ZIPs, I created the missing SH scripts.

I think there is no need for READMEs because nobody is supposed to understand and execute that. They are executed as a part of the maven ant plugin.

@jbescos jbescos force-pushed the issue6799 branch 3 times, most recently from b3e3aa2 to 97f9daf Compare August 8, 2023 10:10
@jbescos
Copy link
Member Author

jbescos commented Aug 8, 2023

I added the readmes for the sh files

@jbescos jbescos force-pushed the issue6799 branch 2 times, most recently from 0fc22ff to 881fb57 Compare August 8, 2023 10:26
dependencies/pom.xml Outdated Show resolved Hide resolved
dependencies/pom.xml Outdated Show resolved Hide resolved
dependencies/pom.xml Outdated Show resolved Hide resolved
dependencies/pom.xml Outdated Show resolved Hide resolved
@jbescos jbescos force-pushed the issue6799 branch 3 times, most recently from 6191844 to 99d1b6a Compare August 8, 2023 13:15
tomas-langer
tomas-langer previously approved these changes Aug 8, 2023
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos
Copy link
Member Author

jbescos commented Aug 8, 2023

TCK Inject failed because I changed the visibility of microprofile/tests/tck/tck-inject/tck-inject-test/src/test/java/io/helidon/microprofile/tests/inject/AtInjectTCKExtension.java from public to package.

I have deleted that class and loaded it from the one that exists in jakarta.inject-tck-2.0.2-bin.zip

@jbescos jbescos merged commit fffdc7a into helidon-io:main Aug 9, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants