Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release call to websocket ByteBuff after using it #7003

Closed
wants to merge 2 commits into from
Closed

Add release call to websocket ByteBuff after using it #7003

wants to merge 2 commits into from

Conversation

asafalima
Copy link

Fixes #7002

@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Jun 15, 2023
@m0mus m0mus requested review from danielkec and spericas June 15, 2023 16:45
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Jun 15, 2023
@asafalima asafalima mentioned this pull request Jun 22, 2023
Closed
@asafalima
Add release call to websocket ByteBuff after using it
685c626 
Signed-off-by: Asaf Alima <asaf.alima@gmail.com>
@asafalima
Add leakDetectionLevel flag to tests
146dde9 
Signed-off-by: Asaf Alima <asaf.alima@gmail.com>
@asafalima asafalima force-pushed the GH-7002-Fix-copied-bytebuf-missing-release branch from faf09a9 to 146dde9 Compare June 22, 2023 13:59
@spericas
Copy link
Member

@asafalima A duplicate of #7042. Like the use of finally. Please make sure not the re-arrange imports or alter spacing in other lines in any future PRs.

@spericas spericas closed this Jun 22, 2023
@asafalima asafalima deleted the GH-7002-Fix-copied-bytebuf-missing-release branch June 22, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkec danielkec Awaiting requested review from danielkec

@spericas spericas Awaiting requested review from spericas

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Websocket integration copied ByteBuf are not released
2 participants
@asafalima @spericas