-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] - Move tracer tags to process #7027
[3.x] - Move tracer tags to process #7027
Conversation
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@tomas-langer this PR addresses the request to move tracer tags to Process tap in Jaeger. Thus tags become parts of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks ok, but I am missing a way to validate this.
This deserves a test (that fails on original code, and works with the changes)
As |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reference the follow up to create a test here. Thanks!
Follow up issue created #7035 |
Resolves #7024 fir Helidon 3.