Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking DB Client #7096

Merged
merged 16 commits into from
Jul 14, 2023
Merged

Blocking DB Client #7096

merged 16 commits into from
Jul 14, 2023

Conversation

Tomas-Kraus
Copy link
Member

@Tomas-Kraus Tomas-Kraus commented Jun 26, 2023

This is still in progress. Currently working on common and JDBC basic functionality
Fixes #6991

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 26, 2023
@Tomas-Kraus Tomas-Kraus linked an issue Jun 26, 2023 that may be closed by this pull request
@Tomas-Kraus Tomas-Kraus self-assigned this Jun 27, 2023
@romain-grecourt romain-grecourt changed the title Issue #6991 - Blocking DB Client Blocking DB Client Jun 28, 2023
@Tomas-Kraus Tomas-Kraus force-pushed the db-client-sync branch 2 times, most recently from 66097fe to 4a7f5f9 Compare June 30, 2023 18:22
@romain-grecourt romain-grecourt marked this pull request as ready for review July 14, 2023 12:52
tomas-langer
tomas-langer previously approved these changes Jul 14, 2023
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge this, as we need to speed up removal of reactive. Follow up issue exists...

Tomas-Kraus and others added 16 commits July 14, 2023 17:08
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
…ial implementation in JDBC

Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com>
- Implement dbclient-mongodb
- Re-work indexed/named parameters
- Convergence between DbClientContext and DbClientExecuteContext
- Generalized intercepted executions
- Removed package-private factory methods in favor of constructors
- Added javadocs
- Copyright and checkstyle fixes
- Fix examples/employee-app
- Fix examples/dbclient
- Add static factory to MongoDbClientBuilder
- Add jsonp
- Remove change in reactive/dbclient/jdbc
…DbMapperProviderImpl to avoid confusion

- Fix module-info to have uses io.helidon.dbclient.spi.DbMapperProvider
- Fix connection close for transaction statements
- Consistent naming (DB Client -> Database Client)
- Minize occurrences of the term "Pokemon" and use {@code Pokemon} when required.
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@barchetta barchetta merged commit 48f0d4a into helidon-io:main Jul 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocking DBClient Part 1
4 participants