-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocking DB Client #7096
Merged
Merged
Blocking DB Client #7096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Jun 26, 2023
Tomas-Kraus
force-pushed
the
db-client-sync
branch
from
June 28, 2023 14:16
ae853ba
to
d1e5865
Compare
Tomas-Kraus
force-pushed
the
db-client-sync
branch
2 times, most recently
from
June 30, 2023 18:22
66097fe
to
4a7f5f9
Compare
tomas-langer
previously approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to merge this, as we need to speed up removal of reactive. Follow up issue exists...
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
…ial implementation in JDBC Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com>
- Implement dbclient-mongodb - Re-work indexed/named parameters - Convergence between DbClientContext and DbClientExecuteContext - Generalized intercepted executions - Removed package-private factory methods in favor of constructors - Added javadocs - Copyright and checkstyle fixes
- Add static factory to MongoDbClientBuilder
- Add jsonp - Remove change in reactive/dbclient/jdbc
…DbMapperProviderImpl to avoid confusion - Fix module-info to have uses io.helidon.dbclient.spi.DbMapperProvider - Fix connection close for transaction statements
- Consistent naming (DB Client -> Database Client) - Minize occurrences of the term "Pokemon" and use {@code Pokemon} when required.
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer
force-pushed
the
db-client-sync
branch
from
July 14, 2023 15:33
326c1b3
to
5bbbe53
Compare
tomas-langer
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still in progress. Currently working on common and JDBC basic functionality
Fixes #6991