Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to do type regeneration turned into an error condition instead of being logged #7155

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Attempt to do type regeneration turned into an error condition instead of being logged #7155

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb3b95f
fix
trentjeff Jul 6, 2023
e02431c
don't regen the same file twice
trentjeff Jul 10, 2023
57c7fba
more fixes
trentjeff Jul 11, 2023
6a8b8fa
checkstyles
trentjeff Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pico/tools/src/main/java/io/helidon/pico/tools/CodeGenFiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,12 +326,12 @@ public Optional<Path> codegenJavaFilerOut(TypeName typeName,
}
return Optional.of(Path.of(javaSrc.toUri()));
} catch (FilerException x) {
messager.log("Failed to write java file: " + x);
messager.error("Failed to write java file: " + x, x);
tomas-langer marked this conversation as resolved.
Show resolved Hide resolved
throw new RuntimeException(x);
} catch (Exception x) {
messager.warn("Failed to write java file: " + x, x);
messager.error("Failed to write java file: " + x, x);
throw new RuntimeException(x);
}

return Optional.empty();
}

/**
Expand Down