Fix gRPC to calculate the correct class name for method request and response types #7228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code in the
Grpc
class assumes that the request and response types for methods will be in the same package as the Java package option in the service photo file. This is not always true because you can import types from other port files. For example in Coherence we import some base Google proto types likeEmpty
.I'm also curios whether line 128 where
.setType
is called in the code below is correct.This code always calls
.setType(io.grpc.MethodDescriptor.MethodType.UNARY)
but the actual method may not be unary.