4.x Support creating routes from standard gRPC bindable services #7384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gRPC API needs to support being able to create routes from standard gRPC service implementations that have been written by extending protobuf generated services. This PR make it possible to create a set of routes by passing either a
BinadbleServiceorServerServiceDefinitionto theGrpcRoutingclass.These changes were required to get our Coherence gRPC client tests to pass when we build the Coherence server side on top of Nima. Our gRPC services have been written in the normal way by extending protobuf generated service classes. It would have been painful to have to register each service method individually with the
GrpcRoutingclass.