4.x: Interceptor creator now uses TypeName (and related changes) #7420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
trentjeff
previously approved these changes
Aug 22, 2023
trentjeff
approved these changes
Aug 22, 2023
dalexandrov
pushed a commit
to dalexandrov/helidon
that referenced
this pull request
Aug 26, 2023
…idon-io#7420) * Interceptor creator now uses TypeName (and related changes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced all cases of using
Stringfor type names withTypeNamein interceptor creator and classes used from there.This impacts extension points for injection, which should not be used yet (and will be marked as incubating/experimental).
Some changes were required as the original code used
HashSetand the tests depended on the order created by it (some cases may still be in the code, I only changed the ones that caused test failure).Also change a couple of places where API was using stuff we do not want (such as
Optionalas a parameter).Resolves #7026
Required for #7411
Documentation
This PR has impact on public API of extensibility for injection.