4.x: Helidon Arquillian module should only depend on MP core #7440
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
jbescos
force-pushed
the
issue6005
branch
6 times, most recently
from
4214101
to
dc26013
Compare
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
| @@ -70,5 +64,9 @@ | |||
| <groupId>org.testng</groupId> | |||
| <artifactId>testng</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Why does it depend on MP metrics?
There was a problem hiding this comment.
It fails otherwise with some injection error I think because of HelidonDeployableContainer#cleanupBaseMetrics, Right now arquillian-helidon requires it.
Update: see the error in the next comment
| <artifactId>helidon-microprofile-metrics</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
This is part of helidon MP core, no need to add it
There was a problem hiding this comment.
There are test failures:
[ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.161 s <<< FAILURE! - in org.jboss.cdi.tck.tests.context.dependent.transientreference.DependentTransientReferenceDestroyedTest
[ERROR] org.jboss.cdi.tck.tests.context.dependent.transientreference.DependentTransientReferenceDestroyedTest.arquillianAfterClass Time elapsed: 0.01 s <<< FAILURE!
org.jboss.weld.exceptions.UnsatisfiedResolutionException: WELD-001334: Unsatisfied dependencies for type MetricRegistry with qualifiers @RegistryType
at org.jboss.weld.bean.builtin.InstanceImpl.checkBeanResolved(InstanceImpl.java:251)
at org.jboss.weld.bean.builtin.InstanceImpl.get(InstanceImpl.java:113)
at io.helidon.microprofile.arquillian.HelidonDeployableContainer.cleanupBaseMetrics(HelidonDeployableContainer.java:583)
mvn dependency:tree does not show helidon-microprofile-metrics
| @@ -36,6 +36,11 @@ | |||
| <artifactId>helidon-microprofile-config</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Why is this here for config TCK? AFAIK metrics are not used from config
There was a problem hiding this comment.
As long as you have this dependency, you need metrics:
<dependency>
<groupId>io.helidon.microprofile.tests</groupId>
<artifactId>helidon-arquillian</artifactId>
</dependency>
We could add it directly in Helidon-Arquillian but I wanted to remove any microprofile dependency from there. I hace the feeling that eventually we will remove it or we will redesign it from helidon-arquillian.
| @@ -30,6 +30,11 @@ | |||
| <name>Helidon Microprofile Tests TCK Core Profile</name> | |||
|
|
|||
| <dependencies> | |||
| <dependency> | |||
There was a problem hiding this comment.
why do you depend on the whole thing here? It should be sufficient to depend on the core, as core profile should be already supported by core.
There was a problem hiding this comment.
Right, for some reason I thought this was testing a small parts of different microprofile things.
| <artifactId>helidon-microprofile-health</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Metrics seem to be added to all poms, including the arqulilian. Please explain
There was a problem hiding this comment.
See the first comments. It is required if you use Helidon Arquillian.
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
|
I have updated helidon-arquillian to not require metrics in every TCK |
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
jbescos
changed the title
…-io#7440) Helidon Arquillian module should only depend on MP core Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Description
Issue #6005
Documentation
None