Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Introduces Lazy OCI Vault ConfigSource #7470

Conversation

ljnelson
Copy link
Member

Introduces a LazyConfigSource version of an OCI Vault ConfigSource and integrates it into the existing OciSecretsConfigSourceProvider. Extracts common functionality into an abstract base class.

Now users can pick what they want.

Documentation impact: none.

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson ljnelson added config P4 OCI java Pull requests that update Java code 4.x Version 4.x labels Aug 25, 2023
@ljnelson ljnelson self-assigned this Aug 25, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 25, 2023
… the lazy configuration source actually attempts to fetch

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljnelson ljnelson merged commit 5ac17bc into helidon-io:main Aug 28, 2023
12 checks passed
ljnelson added a commit to ljnelson/helidon that referenced this pull request Aug 28, 2023
)

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
ljnelson added a commit that referenced this pull request Aug 31, 2023
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x config java Pull requests that update Java code OCA Verified All contributors have signed the Oracle Contributor Agreement. OCI P4
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants